Package deprecation should be case insensitive on version (#10243)

NuGet · Oct 30, 2024 · d6ff752 · d6ff752
1 parent 1593e94
commit d6ff752
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/NuGetGallery/Services/PackageDeprecationManagementService.cs b/src/NuGetGallery/Services/PackageDeprecationManagementService.cs
@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -148,7 +148,7 @@ public async Task<UpdateDeprecationError> UpdateDeprecation(
             foreach (var version in versions)
             {
                 var normalizedVersion = NuGetVersionFormatter.Normalize(version);
-                var package = packages.SingleOrDefault(v => v.NormalizedVersion == normalizedVersion);
+                var package = packages.SingleOrDefault(v => StringComparer.OrdinalIgnoreCase.Equals(v.NormalizedVersion, normalizedVersion));
                 if (package == null)
                 {
                     return new UpdateDeprecationError(
@@ -181,4 +181,4 @@ await _deprecationService.UpdateDeprecation(
             return null;
         }
     }
-}
+}
diff --git a/tests/NuGetGallery.Facts/Services/PackageDeprecationManagementServiceFacts.cs b/tests/NuGetGallery.Facts/Services/PackageDeprecationManagementServiceFacts.cs
@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -856,7 +856,7 @@ private async Task AssertSuccessful(
 
                 var package2 = new Package
                 {
-                    NormalizedVersion = "1.0.0",
+                    NormalizedVersion = "1.0.0-RC1",
                     PackageRegistration = registration
                 };
 
@@ -932,7 +932,7 @@ private async Task AssertSuccessful(
 
                 var service = GetService<PackageDeprecationManagementService>();
 
-                var packageNormalizedVersions = new[] { package.NormalizedVersion, package2.NormalizedVersion };
+                var packageNormalizedVersions = new[] { package.NormalizedVersion, package2.NormalizedVersion.ToLowerInvariant() };
 
                 // Act
                 var result = await InvokeUpdateDeprecation(
@@ -981,4 +981,4 @@ private static Task<UpdateDeprecationError> InvokeUpdateDeprecation(
             }
         }
     }
-}
+}