Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPM & multiple package manager commands #10277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devlead
Copy link

@devlead devlead commented Nov 20, 2024

This PR Fixes #9944

  • Add tab to command palette for Central Package Management XML
  • Support for copying individual package manager commands separately

Example dark theme
NuGetCPM_Standard
NuGet_Tool_Dark

Example light theme
NuGetCPM_Standard_Light
NuGet_Tool_Light

UI Comparison

Package Type Package Manager Current Proposed
Standard .NET Cli image image
Standard Package Manager image image
Standard PackageReference image image
Standard CPM N/A image
Standard Paket CLI image image
Standard Script & Interactive image image
Standard Cake image image
SDK SDK image image
.NET Tool .NET CLI (Global) image image
.NET Tool .NET CLI (Local) image image
.NET Tool Cake image image
.NET Tool Nuke image image
.NET Template .NET Cli image image
Cake Addin Cake image image
Cake Module Cake image image
Cake Recipe Cake image image

@erdembayar
Copy link
Contributor

@OliaG
Could you please take a look at proposed UI change?
Only concern I have is "Central package management" is quite long term compare to other tabs, we're running out of real estate space on that menu.

@zivkan
Copy link
Member

zivkan commented Nov 22, 2024

Perhaps the CPM snippets could be put on the same tab as PackageReference. Prefix one with "if you're not using CPM", and the other with "If you are using CPM". After all, CPM still uses <PackageReference Include="

@OliaG
Copy link

OliaG commented Dec 3, 2024

I actually like the separate tab Central Package Management better as it is suggested originally, but I would capitalize the word "management" in the tab. Should be "Central Package Management"
image

@OliaG OliaG self-requested a review December 3, 2024 23:38
Copy link

@OliaG OliaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the user experience, minor request - to capitalize "management" in the tab name.
I haven't reviewed the implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add tab to command palette for Central Package Management XML
4 participants