Restore auto-add co-owner feature #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelverhagen @skofman1 this is the commit you may want to zoom into: 8ff0fcb |
xavierdecoster
force-pushed
the
dev-issue1419
branch
from
8ff0fcb
to
adc7719
Compare
| @@ -395,6 +395,9 @@ protected override void Load(ContainerBuilder builder) | |||
|
|
|||
| RegisterCookieComplianceService(builder, configuration, diagnosticsService); | |||
|
|
|||
| builder.RegisterType<MicrosoftTeamSubscription>() | |||
| .SingleInstance(); | |||
There was a problem hiding this comment.
Does this really need to be a singleton? Would prefer if it was a new instance each time unless we are concerned and have measure performance impact.
There was a problem hiding this comment.
Changed to instance per lifetime-scope
| private Lazy<List<UserSecurityPolicy>> _policies = new Lazy<List<UserSecurityPolicy>>(InitializePoliciesList, isThreadSafe: true); | ||
|
|
||
| internal const string MicrosoftUsername = "Microsoft"; | ||
| internal const string Name = nameof(MicrosoftTeamSubscription); |
There was a problem hiding this comment.
This should be a const. Refactoring can break behavior here.
joelverhagen
approved these changes
Aug 14, 2018
…otential refactoring of type name
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And select correct target account for package security policies.