[NuGet Symbol Server] Add download symbols support to Package details page #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirx34
requested review from
joelverhagen,
xavierdecoster,
zivkan,
diverdan92,
skofman1,
scottbommarito and
zhhyu
skofman1
reviewed
Aug 16, 2018
src/NuGetGallery/Strings.resx
Outdated
| @@ -949,4 +949,7 @@ If you would like to update the linked Microsoft account you can do so from the | |||
| <value>The previous package version '{0}' is author signed but the uploaded package is unsigned. To avoid this warning, sign the package before uploading.</value> | |||
| <comment>{0} is the previous package's normalized version.</comment> | |||
| </data> | |||
| <data name="SymbolsPackage_PackageNotAvailable" xml:space="preserve"> | |||
| <value>No availabe symbol package found for ID {0} and version {1}.</value> | |||
There was a problem hiding this comment.
please verify text with PM
There was a problem hiding this comment.
@diverdan92 - verify.
There was a problem hiding this comment.
Where is this displayed? Otherwise, verified.
Although, should it be 'symbols package' since the packages can contain multiple symbols?
There was a problem hiding this comment.
This is displayed when you try to download via rest endpoint and its not available, or the latest uploaded symbol package is validating/failed validation/deleted.
|
Probably should get a different icon. Looks great otherwise! |
diverdan92
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to download the snupkg from the package details page.
Addresses #5978 and #5970, also added tests.
The idea is to allow downloading a snupkg if the latest uploaded snupkg is "Available". If there is a newer uploaded snupkg that failed validations or still validating, no download allowed. This is taken care of in the download API and in the package details page view.