Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved the #r directive instructions #8405

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

filipw
Copy link
Contributor

@filipw filipw commented Jan 29, 2021

This is a follow up to #8375

Since #r is not exclusive to F#, it is a bit inaccurate to use the current header for the instructions - it would make sense to use a more generic name for it.
Therefore I propose to rename F# Interactive to .NET Interactive as it then correctly captures both C# and F#.

@cartermp
Copy link

Note that the tab is correct as-is too, since F# Interactive is orthogonal to .NET Interactive. The disjoint nature of package acquisition for C# in "interactive" scenarios when compared to F# likely makes it more challenging to represent.

@filipw
Copy link
Contributor Author

filipw commented Feb 2, 2021

Note that the tab is correct as-is too, since F# Interactive is orthogonal to .NET Interactive.

I meant .NET Interactive as a general class of interactive tools for .NET, not specifically the product .NET Interactive. I have renamed it to Script & Interactive which better conveys the meaning.

This captures both F# and C# if this syntax is supported in a given runner, as the explanation underneath states.

@skofman1 skofman1 added this to the Sprint 2021-02 milestone Feb 8, 2021
@LadyNaggaga
Copy link

PM - .NET Interactive here. @filipw recommend tab name Script & Interactive sounds like a fair description. I have chatted with @cartermp about this as well. A note would need to be included along the lines of #r directive can be used in F# Interactive, C# scripting and .NET Interactive thoughts?

@jcjiang
Copy link

jcjiang commented Feb 22, 2021

That makes sense to me. I agree that we should add the additional context and proceed with the PR.

@agr agr modified the milestones: Sprint 2021-02, Sprint 2021-03 Mar 2, 2021
Base automatically changed from master to main March 18, 2021 01:46
@agr agr modified the milestones: Sprint 2021-03, Sprint 2021-04 Mar 22, 2021
@drewgillies
Copy link
Contributor

Screenshot FYI
image

Copy link
Contributor

@drewgillies drewgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @filipw! Merging.

@drewgillies drewgillies changed the base branch from main to dev April 6, 2021 05:26
@drewgillies drewgillies merged commit 0971952 into NuGet:dev Apr 6, 2021
@ryuyu ryuyu mentioned this pull request Apr 8, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants