Update Service Bus libraries from ServerCommon #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
agr,
dannyjdev,
drewgillies,
joelverhagen,
lyndaidaii,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
as code owners
loic-sharma
commented
Feb 12, 2021
zhhyu
approved these changes
Feb 16, 2021
joelverhagen
approved these changes
Feb 17, 2021
lyndaidaii
approved these changes
Feb 17, 2021
loic-sharma
commented
Mar 23, 2021
| } | ||
|
|
||
| public void Close() => throw new NotImplementedException(); | ||
| public Task CloseAsync() => throw new NotImplementedException(); |
There was a problem hiding this comment.
These methods were added to the ITopicClient interface by: NuGet/ServerCommon#360
|
@zhhyu @joelverhagen @lyndaidaii Hi, I discarded your old approvals as I re-did this PR to upgrade to v2.86.0. Please re-review when available :) |
joelverhagen
approved these changes
Mar 24, 2021
zhhyu
approved these changes
Mar 24, 2021
drewgillies
approved these changes
Mar 24, 2021
loic-sharma
added a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: NuGet/ServerCommon#359
Tracked by: https://github.com/NuGet/Engineering/issues/3650
DEV build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4585079&view=results
DEV test release: https://devdiv.visualstudio.com/DevDiv/_releaseProgress?_a=release-pipeline-progress&releaseId=989991
NuGetGallery.Core build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4585250&view=results