-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotnet local tool instructions tab #8433
Add dotnet local tool instructions tab #8433
Conversation
454e49e
to
ba12605
Compare
I think changing the model to a list of strings (one string per command line) is a good one assuming the copy button still copies the expected text. It's important that the copied text is actually two lines with nothing else added, so that pasting into a terminal behaves nicely. Also, when you add multi-command support, please check what happens with a longer package ID and a narrow screen. Right now the text wrapping looks "good enough" for a single command. We'd want it to look similarly "good enough" 😄 for a command text. |
Hey @augustoproiete, is something I can help out with here or clarify? This seems like a good change and I'd be happy to review the next iteration per my previous comment (#8433 (comment)) whenever you're ready 😃. |
Hey @joelverhagen, thanks for the nudge. I think it's all clear and the ball is in my court now to try to implement the multi-line commands whilst preserving the current copy/paste behavior - though any ideas are welcome. I'll set some time aside this coming weekend and see if I can complete this one. |
Co-authored-by: Joel Verhagen <[email protected]>
ba12605
to
bbee7cf
Compare
@joelverhagen This is ready for round 2. I've updated the view model to allow more than one install command and I'm rendering each command inside of a The copy/paste continues to copy the expected text in all cases, preserving line-breaks (if any). I tested all tabs (Package Manager, .NET CLI, PackageReference, Paket CLI, F# Interactive, Cake, and .NET CLI for Templates), and they continue to display the install commands as expected. Single command with one line- dotnet tool install --global dotnet-ef --version 5.0.4
+ <span class="install-command-row">dotnet tool install --global dotnet-ef --version 5.0.4</span> Multiple commands 🆕+ <span class="install-command-row">dotnet new tool-manifest # if you are setting up this repo
+ </span><span class="install-command-row">dotnet tool install --local dotnet-ef --version 5.0.4</span> Single command with multiple lines (e.g. PackageReference for Development dependencies)- <PackageReference Include="GitVersion.MsBuild" Version="5.6.6">
- <PrivateAssets>all</PrivateAssets>
- <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
- </PackageReference>
+ <span class="install-command-row"><PackageReference Include="GitVersion.MsBuild" Version="5.6.6">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+ </PackageReference></span> |
bbee7cf
to
c000338
Compare
Co-authored-by: Joel Verhagen <[email protected]>
Thanks @augustoproiete! |
Implementation of the tab with installation instructions for .NET local tools:
Rename the existing
.NET CLI
tab to.NET CLI (Global)
Update the info text at the bottom:
.NET CLI (Local)
with the following instructions:Addresses #8373