[nonGallery] adjust backfill logic - remove redundant catch, process null TFMs #8528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuyu
approved these changes
Apr 15, 2021
lyndaidaii
approved these changes
Apr 15, 2021
joelverhagen
approved these changes
Apr 15, 2021
drewgillies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivoting to use
ToShortNameOrNullintroduced the possibility of nulls (which are explicitly returned by this method for theanyTFM), and these need to be excluded from the collection list--these packages were throwing.Also removed a redundant catch, as the calling method has an identical catch which will log collection errors.