Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Make announcers read the version history table data correctly. #8529

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

dannyjdev
Copy link
Contributor

Added tabindex to every td tag on the version history table so that the value can be announced using NVDA or other announcers.

Addresses #8491

@dannyjdev dannyjdev requested a review from a team as a code owner April 15, 2021 19:27
@loic-sharma
Copy link
Contributor

Do we need to add tabindex on all our tables? For example, all our statistics tables here: https://www.nuget.org/stats

Copy link
Contributor

@ryuyu ryuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as keyboard nav isn't wonky with this change, it looks good to me.

@dannyjdev
Copy link
Contributor Author

dannyjdev commented Apr 16, 2021

Do we need to add tabindex on all our tables? For example, all our statistics tables here: https://www.nuget.org/stats

They already have the tabindex=0, and as far as I know they are A11y compliant.

@ryuyu tabindex allows us to traverse the table cell by cell, before we could only traverse the Version and Status column because the values from those rows are links.

@dannyjdev dannyjdev merged commit c0580f6 into dev Apr 16, 2021
@loic-sharma loic-sharma mentioned this pull request Apr 26, 2021
9 tasks
@joelverhagen joelverhagen deleted the dev-dj-a11y-announcer-versionhistory branch August 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants