Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to best practices page on package upload page #8542

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

sophiamfavro
Copy link
Contributor

Added links to best practices page in upload package page

Addresses #8411

image

@sophiamfavro sophiamfavro requested a review from a team as a code owner April 23, 2021 00:16
@ghost
Copy link

ghost commented Apr 23, 2021

CLA assistant check
All CLA requirements met.

</div>
<div id="warning-container">
@ViewHelpers.AlertInfo(@<text>You had an upload in progress. You can continue it here or cancel to restart.</text>)
</div>
Copy link
Contributor

@loic-sharma loic-sharma Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Visual Studio messed with the whitespace here (it tries to auto format Razor code valiantly but the feature is low key busted). We can fix that tomorrow :)

Copy link
Contributor

@drewgillies drewgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've noted the formatting and test code changes still required. There's also web.config. Otherwise :shipit:

src/NuGetGallery/Web.config Outdated Show resolved Hide resolved
@sophiamfavro sophiamfavro merged commit 2e49db6 into dev Apr 23, 2021
@loic-sharma loic-sharma mentioned this pull request Apr 26, 2021
9 tasks
@joelverhagen joelverhagen deleted the sofavro-bestPracUpload branch August 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants