Display version metadata only in an info box #8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…box. Removes metadata from the search results too.
|
@jcjiang I like this idea (thanks, @rocklan!) and it has come at a good time, as we have work going on atm about the package details page: https://twitter.com/jiachenjiang_/status/1385332921750360070?s=20. This may need to be considered in that context rather than taken as a stand-alone change, so it would be good to have your take on this. |
joelverhagen
reviewed
May 5, 2021
src/NuGetGallery/Helpers/ViewModelExtensions/PackageViewModelFactory.cs
Outdated
Show resolved
Hide resolved
joelverhagen
reviewed
May 5, 2021
|
I like this change, good polish prior to the redesign of the page. @jcjiang - could you take a look at this UX change? |
|
This looks great! Ship it! |
…ng the version without metadata
joelverhagen
approved these changes
May 13, 2021
|
Thank you for the continued support in improving nuget.org, @rocklan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the UI so that the version metadata only appears inside an info box on the view package page. Before:
after:
The issue has a screenshot of a warning but it seems to be that an info box might be more appropriate, as version metadata isn't really cause for an alert.
The build metadata is also removed from the search page. Before:
after:
Addresses #7662