Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize image in readme #8568

Merged
merged 1 commit into from
May 10, 2021
Merged

Resize image in readme #8568

merged 1 commit into from
May 10, 2021

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented May 4, 2021

Summary of the changes (in less than 80 characters):

max-width: 100%
means: maximum width in percent of the readme block

If the content is larger than the maximum width, it will automatically change the height of the element.
If the content is smaller than the maximum width, the max-width property has no effect.

before resize:
brforee

after resize:
test

Addresses #8502

@lyndaidaii lyndaidaii requested a review from a team as a code owner May 4, 2021 21:21
@skofman1
Copy link
Contributor

skofman1 commented May 4, 2021

Missing screenshot?

@zhhyu
Copy link
Contributor

zhhyu commented May 5, 2021

What will it look like when reflowing to a smaller device?

@lyndaidaii
Copy link
Contributor Author

What will it look like when reflowing to a smaller device?

it will auto adjust the image size based on the readme container. means it will become smaller when it reflowing to a smaller device. I did test by making browser smaller, it looks good.

@lyndaidaii lyndaidaii merged commit 2050996 into dev May 10, 2021
@lyndaidaii lyndaidaii mentioned this pull request May 18, 2021
5 tasks
@joelverhagen joelverhagen deleted the readmeImage branch August 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants