[non-Gallery] Add a non-locked monitoring cursor for inspection during backfill job #8577
Conversation
drewgillies
changed the title
| // Write a monitoring cursor (not locked) so for a large job we can inspect progress | ||
| if (!string.IsNullOrEmpty(MonitoringCursorFileName)) | ||
| { | ||
| File.WriteAllText(MonitoringCursorFileName, cursorTime.Value.ToShortDateString()); |
There was a problem hiding this comment.
It'd probably be more future proof just to write the full cursor value. Who knows when we'll need that more precise value.
| @@ -399,6 +407,12 @@ private async Task CommitBatch(EntitiesContext context, FileCursor cursor, Logge | |||
| if (cursorTime.HasValue) | |||
| { | |||
| await cursor.Write(cursorTime.Value); | |||
There was a problem hiding this comment.
Could we modify FileCursor to have this same behavior of not keeping the file handle open forever?
There was a problem hiding this comment.
I was wondering about this and thought this was a less intrusive fix. But I could take a look.
|
|
@joelverhagen the problem there is when you no longer have access to the user session that initiated the process. You can only view the users tab in the task manager to see if it's still chewing CPU, and there's no available console.out. |
| @@ -275,6 +277,12 @@ public async Task Update(SqlConnection connection, string fileName) | |||
| { | |||
| await CommitBatch(context, cursor, logger, metadata.Created); | |||
| counter = 0; | |||
|
|
|||
| // Write a monitoring cursor (not locked) so for a large job we can inspect progress | |||
| if (!string.IsNullOrEmpty(MonitoringCursorFileName)) | |||
There was a problem hiding this comment.
I am a little curious about the reason to log the cursor time again here, because it seems that "CommitBatch" at line 278 has already logged it, is it?
There was a problem hiding this comment.
Good catch, @zhhyu --this is a double-up. I've moved this piece of logic to the collect method.
drewgillies
force-pushed
the
dg-backfill-addmonitoringcursor
branch
from
8c65bb5
to
8830651
Compare
This makes monitoring a large-scale collect/update job a lot easier to track--it writes a monitoring cursor (date only) file every time it updates the locked cursor file. Not being locked, the monitoring cursor can be inspected randomly to determine progress.