Add banner to all pages #8579

lyndaidaii · 2021-05-12T19:17:04Z

Summary of the changes (in less than 80 characters):

before: banner only show on the home page

after: banner show on all pages
package details page:

Upload package page:

Addresses #8525

joelverhagen · 2021-05-12T19:34:19Z

Do we want it on all pages? How did we pick this specific set?

lyndaidaii · 2021-05-12T19:39:30Z

Do we want it on all pages? How did we pick this specific set?

yes, we want to it on all pages if this possible. the reason why pick those pages is it has high traffic to thoses pages, especially display package details pages. it has traffic from PMUI or google.
Discussed with Chris, I will add more banner to pages like manage package package for authors

joelverhagen · 2021-05-12T22:47:06Z

src/NuGetGallery/Views/Users/Packages.cshtml

@@ -3,6 +3,7 @@
 @{
    ViewBag.Title = "Manage My Package";
    ViewBag.Tab = "Packages";
+    ViewBag.DisplayBanner = Model.DisplayBannerFeatureEnabled;


Can we do this in the Layout.cshtml + NuGetViewBase?

https://github.com/NuGet/NuGetGallery/blob/main/src/NuGetGallery/Views/Shared/Gallery/Layout.cshtml
https://github.com/NuGet/NuGetGallery/blob/main/src/NuGetGallery/Views/NuGetViewBase.cs

This would hit every page.

I am not sure about this approach. if we include in NuGetViewBase, which means flag for banner will be in the configure file instead of feature flag json file. let me know if my thinking is in right track?

shishirx34 · 2021-05-12T23:10:12Z

Can we make this banner dismissible? It is very annoying to see it constantly for folks who don't care. It was tolerable when it was only on the home page but the user experience is terrible once we enable this on all pages. When asking for survey we should only ask it once when the page is opened after that allow it to be dismissible or it should auto-dismiss i.e. hide it after sometime if the user doesn't click on it, or say user logs in. Even if the user decides to respond to a survey why would we want to show the banner again.

shishirx34

I would avoid putting this on all pages, or at least redesign the banner to be dismissible.

lyndaidaii · 2021-05-13T16:59:49Z

I would avoid putting this on all pages, or at least redesign the banner to be dismissible.

The reason why we want add to most of pages is because that we are getting small amount of customers' responses this time comparing last time. We want to get more feedback with more banner visible in more pages

jcjiang · 2021-05-13T17:42:27Z

@shishirx34 Some more context to not letting the banner be dismissed - the main reason why we decided to sidestep that functionality (for now) is because 1) saving the dismissed state for future sessions from the users would require additional engineering work that given the 2) relatively short windows - usually a week or two - during which the survey is out, might not be worth it.

Completely agree though that as we have surveys that are out for longer or are more visually distracting, we should allow the banner to be dismissed and/or not show on all pages.

shishirx34 · 2021-05-13T18:59:04Z

@jcjiang - I disagree. Even the period of 1-2 weeks is too long of a period to showcase this anti-pattern. We get millions of views every week on the gallery. I've had personal experience with some users being annoyed when asked to give feedback for not using 2FA after login and this was a one time pop-up. I am certain lots of users will find this annoying. Being persistent and annoying at showing this banner to users just to get the feedback is not a good way to get the data, moreover, it disinclines the users to actually follow through.

I remember that we had some form of survey (HATS?) where we had a "feedback" side rollout pop-up which was a much better way of getting feedback (and this was designed by ux team). This banner is pretty loud with a color scheme that doesn't really go with the site for continuous view and at the top of the page, designed by us with no ux lead or user research. Let's say a user does provide you with the feedback, we still continue to show this banner to that user which isn't a good user experience. I believe this banner was introduced for BLM support and now we are extending, probably misusing, it for survey purpose.

We should either find a different way to get feedback, or at the very least invest engineering effort on making this dismissible so that it is reusable in the future.

We should have a discussion offline if you still disagree.

/cc: @skofman1

lyndaidaii · 2021-05-14T19:31:15Z

After discussion, we decide to display banner to all pages now due to reasons following:

communication overhead with customers. less confusion for customers since survey banner is alive already.
the reason why we are getting low response is not clear, we will investigate more, improve experience after getting more feedback from customers.
dismissble button requires some details info(how long banner will be dismiss etc), more engineering/PM time is required, which potentially makes some annoying time for customers.

We will add dismissible button for next NuGet.org survey to improve customer experience.
Created issue for tracking: #8582

Thanks for all input and all considerations!

src/NuGetGallery/Controllers/AppController.cs

zhhyu · 2021-05-16T00:44:58Z

tests/NuGetGallery.Facts/Controllers/AppControllerFacts.cs

                cookieExpirationService.Setup(e => e.ExpireAnalyticsCookies(It.IsAny<HttpContextBase>()));
+                featureFlagsService.Setup(e => e.IsDisplayBannerEnabled()).Returns(false);


It's better to have a separate test for the banner flag.

joelverhagen · 2021-05-17T19:04:06Z

tests/NuGetGallery.Facts/Controllers/AppControllerFacts.cs

+                InvokeOnActionExecutedMethod(controller.ControllerContext, httpContext.Object, controller);
+
+                // Assert
+                Assert.False(controller.ViewBag.CanWriteAnalyticsCookies);


Why assert on analytics cookies? There is already a UT up there to do the same.

joelverhagen

Please limit UT assertions to only describe the UT name, i.e. the name of the "fact".

zhhyu · 2021-05-17T20:49:38Z

tests/NuGetGallery.Facts/Controllers/AppControllerFacts.cs

                cookieExpirationService.Setup(e => e.ExpireAnalyticsCookies(It.IsAny<HttpContextBase>()));
+                featureFlagsService.Setup(e => e.IsDisplayBannerEnabled()).Returns(false);


There is no need to verify the banner flag in these two tests for cookies, if we have another test to cover it.

zhhyu · 2021-05-17T20:58:18Z

tests/NuGetGallery.Facts/Controllers/AppControllerFacts.cs

+                // Arrange
+                var cookieExpirationService = GetMock<ICookieExpirationService>();
+                var featureFlagsService = GetMock<IFeatureFlagService>();
+                cookieExpirationService.Setup(e => e.ExpireAnalyticsCookies(It.IsAny<HttpContextBase>()));


You can also remove this setup and verification because we test the banner flag here.

it's private method. I don't think we could remove the set up. let me know if I am wrong.

lyndaidaii requested a review from a team as a code owner May 12, 2021 19:17

lyndaidaii changed the base branch from main to dev May 12, 2021 19:17

lyndaidaii changed the title ~~add banner to display, upload, list package pages~~ Add banner to display, upload, list package pages May 12, 2021

joelverhagen reviewed May 12, 2021

View reviewed changes

shishirx34 suggested changes May 12, 2021

View reviewed changes

banner to all pages

6546ecb

lyndaidaii force-pushed the banner branch from 8e9515c to 6546ecb Compare May 14, 2021 19:00

remove the banner flag from home display view model

547d80e

lyndaidaii requested review from shishirx34 and joelverhagen May 14, 2021 19:17

lyndaidaii mentioned this pull request May 14, 2021

Redesign banner on NuGet.org #8582

Open

lyndaidaii added 2 commits May 14, 2021 13:44

fix unit test

6961f9d

remove space line

69b16eb

lyndaidaii changed the title ~~Add banner to display, upload, list package pages~~ Add banner to all pages May 14, 2021

shishirx34 approved these changes May 14, 2021

View reviewed changes

zhhyu reviewed May 16, 2021

View reviewed changes

src/NuGetGallery/Controllers/AppController.cs Outdated Show resolved Hide resolved

zhhyu reviewed May 16, 2021

View reviewed changes

lyndaidaii added 5 commits May 17, 2021 10:39

fix name

ce42d2c

rename

848199a

fix unit test

ccfc30c

fix unit test

173953c

add unit test

311fa69

lyndaidaii requested a review from zhhyu May 17, 2021 18:54

joelverhagen reviewed May 17, 2021

View reviewed changes

joelverhagen approved these changes May 17, 2021

View reviewed changes

fix unit test

29625a5

zhhyu reviewed May 17, 2021

View reviewed changes

zhhyu approved these changes May 17, 2021

View reviewed changes

fix unit test

41f450a

lyndaidaii merged commit 7dc5f3d into dev May 18, 2021

lyndaidaii mentioned this pull request May 18, 2021

[2021.05.18] Deployment #8585

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add banner to all pages #8579

Add banner to all pages #8579

lyndaidaii commented May 12, 2021 •

edited

Loading

joelverhagen commented May 12, 2021

lyndaidaii commented May 12, 2021 •

edited

Loading

joelverhagen May 12, 2021

lyndaidaii May 12, 2021

shishirx34 commented May 12, 2021 •

edited

Loading

shishirx34 left a comment

lyndaidaii commented May 13, 2021 •

edited

Loading

jcjiang commented May 13, 2021

shishirx34 commented May 13, 2021 •

edited

Loading

lyndaidaii commented May 14, 2021 •

edited

Loading

zhhyu May 16, 2021

joelverhagen May 17, 2021

joelverhagen left a comment

zhhyu May 17, 2021

zhhyu May 17, 2021 •

edited

Loading

lyndaidaii May 18, 2021 •

edited

Loading

		cookieExpirationService.Setup(e => e.ExpireAnalyticsCookies(It.IsAny<HttpContextBase>()));
		featureFlagsService.Setup(e => e.IsDisplayBannerEnabled()).Returns(false);

Add banner to all pages #8579

Add banner to all pages #8579

Conversation

lyndaidaii commented May 12, 2021 • edited Loading

joelverhagen commented May 12, 2021

lyndaidaii commented May 12, 2021 • edited Loading

joelverhagen May 12, 2021

Choose a reason for hiding this comment

lyndaidaii May 12, 2021

Choose a reason for hiding this comment

shishirx34 commented May 12, 2021 • edited Loading

shishirx34 left a comment

Choose a reason for hiding this comment

lyndaidaii commented May 13, 2021 • edited Loading

jcjiang commented May 13, 2021

shishirx34 commented May 13, 2021 • edited Loading

lyndaidaii commented May 14, 2021 • edited Loading

zhhyu May 16, 2021

Choose a reason for hiding this comment

joelverhagen May 17, 2021

Choose a reason for hiding this comment

joelverhagen left a comment

Choose a reason for hiding this comment

zhhyu May 17, 2021

Choose a reason for hiding this comment

zhhyu May 17, 2021 • edited Loading

Choose a reason for hiding this comment

lyndaidaii May 18, 2021 • edited Loading

Choose a reason for hiding this comment

lyndaidaii commented May 12, 2021 •

edited

Loading

lyndaidaii commented May 12, 2021 •

edited

Loading

shishirx34 commented May 12, 2021 •

edited

Loading

lyndaidaii commented May 13, 2021 •

edited

Loading

shishirx34 commented May 13, 2021 •

edited

Loading

lyndaidaii commented May 14, 2021 •

edited

Loading

zhhyu May 17, 2021 •

edited

Loading

lyndaidaii May 18, 2021 •

edited

Loading