Add link for reserved namespace error during package upload #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend including the link as part of the statement, something like: ... or re-upload the package with a different ID. Click here to learn more about the Package ID prefix reservation. |
| Assert.Equal(Strings.UploadPackage_IdNamespaceConflict, (result.Data as JsonValidationMessage[])[0].PlainTextMessage); | ||
| Assert.Null((result.Data as JsonValidationMessage[])[0].RawHtmlMessage); | ||
| Assert.Equal(Strings.UploadPackage_IdNamespaceConflictHtml, (result.Data as JsonValidationMessage[])[0].RawHtmlMessage); | ||
| Assert.Null((result.Data as JsonValidationMessage[])[0].PlainTextMessage) ; |
There was a problem hiding this comment.
Suggested change
| Assert.Null((result.Data as JsonValidationMessage[])[0].PlainTextMessage) ; | |
| Assert.Null((result.Data as JsonValidationMessage[])[0].PlainTextMessage); |
joelverhagen
approved these changes
May 28, 2021
|
Here's an interesting perspective on using "here" for link text: https://www.smashingmagazine.com/2012/06/links-should-never-say-click-here/ |
|
Can we say (with the full text as link): |
loic-sharma
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (in less than 80 characters):
Add link to message when there is conflict of namespace during uploading package
After changes:
Addresses #8397