Styled Header for new display package page #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Jun 16, 2021
loic-sharma
reviewed
Jun 16, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
reviewed
Jun 17, 2021
loic-sharma
approved these changes
Jun 18, 2021
zhhyu
reviewed
Jun 20, 2021
| } | ||
|
|
||
| .prefix-reserve-title { | ||
| background-color: #F3F2F1; |
There was a problem hiding this comment.
nit: will it be better if we also use some shared color variable here?
zhhyu
reviewed
Jun 20, 2021
| .prefix-reserve-label { | ||
| font-size: 14px; | ||
| font-weight: 400; | ||
| color: #2F6FA7; |
There was a problem hiding this comment.
nit: will it be better if we also use some shared color variable here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
This PR is all about styling the header of the new display package page. I changed the sizing, spacing, and colors of the header elements to match the redesign mock ups. I also added a "prefix reserved" label that links to the ID prefix reservation docs. The goal of this PR was do all the necessary changes in the header except for the installation instructions, so I have left them untouched and will do those changes in a later PR. Here is what the final product looks like
Testing
I tested all the links to make sure that they worked with the feature flag on and off, checked the console to make sure that there were no errors in the .js file, and resized the page to make sure the styling stayed the same.
This addresses issue #8601