modify pettry link #8658
Merged
modify pettry link #8658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2021 23:08
| [InlineData("My package is https://www.microsoft.com#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/.", "My package is <a href=\"https://www.microsoft.com/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/\" rel=\"nofollow\">https://www.microsoft.com/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/</a>.")] | ||
| [InlineData("My package is http://www.microsoft.com#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/.", "My package is <a href=\"https://www.microsoft.com/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/\" rel=\"nofollow\">https://www.microsoft.com/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/</a>.")] | ||
| [InlineData("My package is https://www.microsoft.com##https://nuget.org/packages/WindowsAzure.Storage/9.3.1/.", "My package is <a href=\"https://www.microsoft.com/##https://nuget.org/packages/WindowsAzure.Storage/9.3.1/\" rel=\"nofollow\">https://www.microsoft.com/##https://nuget.org/packages/WindowsAzure.Storage/9.3.1/</a>.")] | ||
| [InlineData("My package is https://www.nuget.org#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/.", "My package is <a href=\"https://www.nuget.org/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/\" rel=\"nofollow\">https://www.nuget.org/#https://nuget.org/packages/WindowsAzure.Storage/9.3.1/</a>.")] | ||
| public void ConvertsPackageUrlsToLinksWithShortText(string input, string expected) |
There was a problem hiding this comment.
Perhaps I am misunderstanding, but shouldn't these newly added tests be on ConvertsUrlsToLinks since the short text isn't being used?
joelverhagen
approved these changes
Jun 24, 2021
loic-sharma
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (in less than 80 characters):
For all rootsite is not nuget.org, we will not consider to short link as package details page
Addresses https://github.com/NuGet/Engineering/issues/3199