Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microbuild] NuGetGallery Update ServerCommon commit on build.ps1. #8661

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

dannyjdev
Copy link
Contributor

@dannyjdev dannyjdev commented Jun 25, 2021

  • BuildBranch was changed to BuildBranchCommit to reflect the actual value.
  • BuildBranchCommit now points to the newest commit that's needed for migrating to new Agent Pools.

@dannyjdev dannyjdev requested a review from a team as a code owner June 25, 2021 21:40
build.ps1 Outdated
wget -UseBasicParsing -Uri "https://raw.githubusercontent.com/NuGet/ServerCommon/$BuildBranch/build/init.ps1" -OutFile "$PSScriptRoot/build/init.ps1"
. "$PSScriptRoot/build/init.ps1" -BuildBranch "$BuildBranch"
wget -UseBasicParsing -Uri "https://raw.githubusercontent.com/NuGet/ServerCommon/$BuildBranchCommit/build/init.ps1" -OutFile "$PSScriptRoot/build/init.ps1"
. "$PSScriptRoot/build/init.ps1" -BuildBranchCommit "$BuildBranchCommit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. "$PSScriptRoot/build/init.ps1" -BuildBranchCommit "$BuildBranchCommit"
. "$PSScriptRoot/build/init.ps1" -BuildBranchCommit $BuildBranchCommit

@dannyjdev dannyjdev merged commit 781eaea into dev Jun 28, 2021
@dannyjdev dannyjdev mentioned this pull request Jun 29, 2021
5 tasks
@joelverhagen joelverhagen deleted the dev-dj-microbuild-gallery-cloudvault branch August 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants