Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip html comments from markdown #8667

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Strip html comments from markdown #8667

merged 1 commit into from
Jul 13, 2021

Conversation

CyberAndrii
Copy link
Contributor

Closes #8627

@CyberAndrii CyberAndrii requested a review from a team as a code owner July 2, 2021 20:50
@drewgillies
Copy link
Contributor

@lyndaidaii I've pushed this as pr-8667 on origin to trigger CI. You may wish to look these changes over and test them before approving/merging.

@lyndaidaii
Copy link
Contributor

LGTM, :shipit:

@lyndaidaii
Copy link
Contributor

I tested locally it was working perfectly. Thanks for your contribution. @CyberAndrii

@drewgillies, feel free to merge it.

@lyndaidaii lyndaidaii merged commit 7557469 into NuGet:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyndaidaii lyndaidaii lyndaidaii approved these changes

@drewgillies drewgillies drewgillies approved these changes

Assignees

@lyndaidaii lyndaidaii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for <!-- --> comments in README.mds
3 participants
@CyberAndrii @drewgillies @lyndaidaii