[Redesign] Update installation instructions #8690
Conversation
…orrect instructions for selected installation method
loic-sharma
force-pushed
the
loshar-installation-instructions
branch
from
fbe830c
to
c41185f
Compare
|
Have you tested multi-line commands ( |
|
@joelverhagen Yup, I added a bunch of screenshots for a bunch of different scenarios including multi-line, long package IDs, mobile, etc... Let me know if I missed any fun cases! |
|
These two lines look different length, i.e. it looks like the command text is not vertically centered. Intentional? |
|
@joelverhagen Yup that's intentional. It is added when there is an alert below for spacing, but the spacing is equal when there is no alert below. It looks a bit cramped if we remove that spacing below:
/cc @jcjiang |
|
@jcjiang confirmed they approve of the extra padding on the installation instructions if they have a banner below. |
| }); | ||
|
|
||
| // Used to switch installation instructions when a new package manager is selected | ||
| function updatePackageManager(newPackageManagerId, updateSelector) { |
There was a problem hiding this comment.
I see that "updateSelector" is mainly used when restoring the preferred selection from the local storage. So we can set packageManagerSelector[0].value = preferredPackageManagerId; after line 63 updatePackageManager(preferredPackageManagerId, true);, and then there is no need to keep the argument "updateSelector" any more.
I don't feel strong, but this may be more clean and easier to follow.
Addresses #8602
Screenshots
Default screenshot...
Package with long ID:
Installation instructions with banners below...
Multi-line installation instructions...
.NET Tools...
⚠ .NET Template...
⚠ NOTE: There is only one package manager that supports .NET Templates today. The UI has a dropdown with only a single option.
Mobile...
FYI the installation instructions are sideways scrollable. You can swipe (or is it pan?) to see the text: