Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display NuGet Package Explorer link on details page. #8697

Merged
merged 7 commits into from
Jul 22, 2021

Conversation

dannyjdev
Copy link
Contributor

Summary of the changes:

  • A link was added for both detail page versions (current, tabs).
  • The link sends you to a nuget.info page where you can see the package assets.
  • The link will only be displayed when the package is "Available", to avoid sending the user to a broken/non ready page.
  • When you click the link it goes to a new page instead of using the current one.
  • Minor refactor to the FuGet link to behave like this one.

DisplayPackage page:

DisplayPackage

DisplayPackageV2 page:

DisplayPackageV2

Addresses #8428

@dannyjdev dannyjdev requested a review from a team as a code owner July 20, 2021 20:17
<i class="ms-Icon ms-Icon--FabricFolderSearch" aria-hidden="true" aria-label="@disclaimer" title="@disclaimer"></i>
<a href="@Model.NuGetPackageExplorerUrl" data-track="outbound-nugetpackageexplorer-url"
aria-label="open in NuGet Package Explorer"
title="Explore additional package info on NuGet Package Explorer" target="_blank" rel="nofollow">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be using target="_blank". This is different behavior than the project URL or repo URL which I don't see as categorically different. However I don't feel strongly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the motivation for this change on the FuGet link? Perhaps I am missing something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With target="_blank" we open a new browser tab with the Fuget/NPE page while keeping the current NuGet display package page. Since those links sends you to a 3rd party site, I think it's better to have our NuGet display package page open while the user go and see those sites for more information. Basically to avoid the user to go backwards on the browser history to return to the same NuGet display package page.

@joelverhagen
Copy link
Member

Looks good to me! Thanks for cleaning up the old, IE-only thing 👏.

Wanna take a final look, @jcjiang + @clairernovotny?

@dannyjdev dannyjdev merged commit 92104dc into dev Jul 22, 2021
@dannyjdev dannyjdev deleted the dev-dj-nugetpackageexplorer branch August 3, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants