Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Address sidebar feedback #8725

Merged
merged 1 commit into from
Aug 2, 2021
Merged

[Redesign] Address sidebar feedback #8725

merged 1 commit into from
Aug 2, 2021

Conversation

loic-sharma
Copy link
Contributor

@loic-sharma loic-sharma commented Jul 31, 2021

I recommend reviewing without whitespace changes:

image

Here is a summary of the changes:

-* "About package" section
+* "About" section
    * Last updated date
    * Project website
    * Source repository
    * License info
-  
-    <whitespace>
- 
    * Download package
    * Download symbols
+   * "Open in NuGet package explorer" link
+   * "Open in FuGet package explorer" link
+   * "Report package" link
+
+* "Manage" section
    * "Manage package" link
    * "Delete symbols" link
    * "Reflow package" link
    * "Revalidate package" link
    * "Revalidate symbols" link
    * "View validations" link
+   * "Contact support" link 
-   * "Open in NuGet package explorer" link
-   * "Open in FuGet package explorer" link
-   * "Contact support" or "Report package" link
Screenshot if logged out...

image

Screenshot if logged in as owner...

image

Screenshot if logged in as admin...

image

Addresses #8717

@loic-sharma loic-sharma requested a review from a team as a code owner July 31, 2021 00:35
@loic-sharma loic-sharma changed the base branch from loshar-overflow to loshar-overflow-backup August 2, 2021 17:13
@loic-sharma loic-sharma changed the base branch from loshar-overflow-backup to loshar-overflow August 2, 2021 17:19
@loic-sharma loic-sharma marked this pull request as draft August 2, 2021 17:21
@loic-sharma loic-sharma marked this pull request as ready for review August 2, 2021 18:04
Copy link
Contributor

@dannyjdev dannyjdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

Base automatically changed from loshar-overflow to dev August 2, 2021 23:11
@loic-sharma loic-sharma merged commit bd3ca6d into dev Aug 2, 2021
@joelverhagen joelverhagen deleted the loshar-sidebar branch August 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants