-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload page UX polish #9281
Upload page UX polish #9281
Conversation
The new font on the warning message looks like a serif font. I don't think we use serif fonts anywhere on the site right now. Was this intentional? The "How to include a license within the package." is written like a sentence but it's more a sentence fragment. Should it be an imperative like "See how ..."? |
The gray "You had an upload in progress. You can continue here or cancel to restart seems a bit ugly and redundant. Do you think we can remove it? Or move it to the bottom near the cancel button? Just a thought. |
What do you think about adding a feature flag for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small comments and questions.
The text for the individual Readme and License warnings also looks smaller than the surrounding text (in addition to being a different font). That wasn't the case with the previous UI. Even if we don't make them all use the same font, should we increase the font size for these warnings to make everything the same size? |
Added feature flag. |
@@ -108,6 +108,12 @@ | |||
"SiteAdmins": false, | |||
"Accounts": [], | |||
"Domains": [] | |||
}, | |||
"NuGetGallery.DisplayUploadWarningV2": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we choose a flight over a flag here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flight could restrict to users specific.
Summary of the changes (in less than 80 characters):
Additionally UX is reviewed by UX team
Before:
After:
Feature flag is off:
Feature flag is on
Addresses