Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload page UX polish #9281

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Upload page UX polish #9281

merged 7 commits into from
Oct 31, 2022

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Oct 24, 2022

Summary of the changes (in less than 80 characters):

  • Add feature flag
    • Add warning when package without readme
    • Reword warning when package without license, align with readme
    • Upload collapse hide when there is metadata display in verify
  • Display unnecessary metadata when is not specified
  • Remove Italic font

Additionally UX is reviewed by UX team

Before:
Screenshot 2022-10-24 150028

After:
Feature flag is off:
Screenshot 2022-10-26 160341

Feature flag is on
Screenshot 2022-10-26 160308

Addresses

@lyndaidaii lyndaidaii requested a review from a team as a code owner October 24, 2022 22:02
@lyndaidaii lyndaidaii changed the title UI cleanup Upload page UX polish Oct 24, 2022
@joelverhagen
Copy link
Member

The new font on the warning message looks like a serif font. I don't think we use serif fonts anywhere on the site right now. Was this intentional?

The "How to include a license within the package." is written like a sentence but it's more a sentence fragment. Should it be an imperative like "See how ..."?

cc @clairernovotny

@joelverhagen
Copy link
Member

The gray "You had an upload in progress. You can continue here or cancel to restart seems a bit ugly and redundant. Do you think we can remove it? Or move it to the bottom near the cancel button? Just a thought.

@joelverhagen
Copy link
Member

What do you think about adding a feature flag for this?

Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments and questions.

@advay26
Copy link
Member

advay26 commented Oct 25, 2022

The new font on the warning message looks like a serif font. I don't think we use serif fonts anywhere on the site right now. Was this intentional?

The text for the individual Readme and License warnings also looks smaller than the surrounding text (in addition to being a different font). That wasn't the case with the previous UI. Even if we don't make them all use the same font, should we increase the font size for these warnings to make everything the same size?

image

@lyndaidaii
Copy link
Contributor Author

lyndaidaii commented Oct 26, 2022

Added feature flag.
UI cleanup is not controlled by feature flag. (Display unnecessary metadata when is not specified
and Remove Italic font).
Feature flag only impact the warning messages.

@lyndaidaii
Copy link
Contributor Author

CI push
Screenshot 2022-10-26 193344

@@ -108,6 +108,12 @@
"SiteAdmins": false,
"Accounts": [],
"Domains": []
},
"NuGetGallery.DisplayUploadWarningV2": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we choose a flight over a flag here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flight could restrict to users specific.

@lyndaidaii lyndaidaii merged commit a3ccd39 into dev Oct 31, 2022
@joelverhagen joelverhagen deleted the uploadPageRedesign branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants