Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed dotnet new example #9309

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Conversation

vlada-shubina
Copy link
Contributor

Starting .NET 7.0, dotnet new --install became dotnet new install.
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-new-install

Therefore changed syntax in example

ryuyu and others added 2 commits November 9, 2022 17:29
@vlada-shubina vlada-shubina requested a review from a team as a code owner November 14, 2022 20:46
@vlada-shubina
Copy link
Contributor Author

@baronfel fyi

@joelverhagen
Copy link
Member

Thanks for the contribution, @vlada-shubina!

I'm curious about the timing of this change, i.e. when should it go live on NuGet.org. Should it wait until a certain % of users move to .NET 7? Or do you think we should just go for it since .NET 7 is GA'd?

What is the behavior if you use the new syntax on the old CLI or the old syntax on the new CLI?

@vlada-shubina
Copy link
Contributor Author

@joelverhagen

new syntax doesn't work in previous versions
old syntax works in .NET 7 with warning:

>dotnet new --install Boxed.Templates  
Warning: use of 'dotnet new --install' is deprecated. Use 'dotnet new install' instead.
For more information, run:
   dotnet new install -h

The following template packages will be installed:
   Boxed.Templates
...

aka.ms/dotnet-new leads to https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-new which explains new syntax almost on top. @baronfel do you know the adoption of .NET 7? when do you think we should go for the change?

@joelverhagen
Copy link
Member

I spoke with @baronfel offline. Let's proceed with this chance given it is the new syntax, it's GA'd, and folks are actively adoption .NET 7.

@joelverhagen
Copy link
Member

@vlada-shubina, thanks again for pushing this. I'll run the change through the CI and get the verification and deployment process rolling.

@joelverhagen joelverhagen changed the base branch from main to dev November 16, 2022 17:19
@joelverhagen
Copy link
Member

FYI I changed the base branch to dev which is where we start during verification.

@joelverhagen joelverhagen merged commit 3db2816 into NuGet:dev Nov 21, 2022
@joelverhagen joelverhagen self-assigned this Nov 21, 2022
@joelverhagen
Copy link
Member

Merged to dev. We'll take this to PROD (www.nuget.org) soon. Thanks again, @vlada-shubina!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants