Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes en-us to improve documentation localization #9325

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Conversation

JonDouglas
Copy link
Contributor

Summary of the changes (in less than 80 characters):

  • Removes en-us from many locations to improve documentation localization.

ryuyu and others added 3 commits November 9, 2022 17:29
[ReleasePrep][2022.11.09]RI of dev into main
[ReleasePre][2022.11.22] FI of dev into main
@JonDouglas JonDouglas requested a review from a team as a code owner December 9, 2022 20:51
keylime-unicorn
keylime-unicorn previously approved these changes Dec 9, 2022
@JonDouglas
Copy link
Contributor Author

Did I break resource files on mac? I can't see CI so I won't know.

@joelverhagen
Copy link
Member

Looks like we have some explicit assertions on the warning message.

    NuGetGallery.PackagesControllerFacts+TheDisplayPackageMethod.OneSecondCacheTime [SKIP]
      Flaky test, tracked by issue https://github.com/NuGet/NuGetGallery/issues/8231
    NuGetGallery.Authentication.V3HasherTests.ProcessingTimesForSuccessfulAuthAndFailedAuthAreSimilar [SKIP]
      This test is not deterministic. Lets not run it as part of CI
##[error]    NuGetGallery.PackageMetadataValidationServiceFacts+TheValidateMetadataBeforeUploadAsync.WarnsAboutPackagesWithoutWhenEmbeddedReadmeNotEnabledAndDisplayUploadWarningV2Enabled [FAIL]

      Assert.StartsWith() Failure:
      Expected: Readme missing. Go to https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.
      Actual:   Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.
      Stack Trace:
        tests\NuGetGallery.Facts\Services\PackageMetadataValidationServiceFacts.cs(0,0): at NuGetGallery.PackageMetadataValidationServiceFacts.TheValidateMetadataBeforeUploadAsync.<WarnsAboutPackagesWithoutWhenEmbeddedReadmeNotEnabledAndDisplayUploadWarningV2Enabled>d__71.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
##[error]    NuGetGallery.PackageMetadataValidationServiceFacts+TheValidateMetadataBeforeUploadAsync.WarnsAboutPackagesWithoutReadmeWhenDisplayUploadWarningV2Enabled [FAIL]

      Assert.StartsWith() Failure:
      Expected: Readme missing. Go to https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.

We have the strings hard coded unit some unit tests, so these also need to be fixed up.

C'mon man, throwing your mac under the bus so quickly? 😄 (I wouldn't have been surprised if some line ending stuff showed up :))

@Mikejo5000
Copy link

Will it take much work to fix the unit tests and merge this? Thanks!

@joelverhagen joelverhagen merged commit ced00b4 into dev Jan 10, 2023
@joelverhagen joelverhagen deleted the string-cheese branch January 10, 2023 20:59
@Mikejo5000
Copy link

@joelverhagen @JonDouglas Thanks!

@joelverhagen
Copy link
Member

@Mikejo5000, this is deployed to www.nuget.org now. Thanks for bringing attention to this! @JonDouglas, thanks for doing the hard work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants