Selectively render the vulnerable element on manage packages page #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly improves performance for the manage packages page. For a user with 1000 package IDs, it went from a 7 second page render time to 3 seconds. The .get(0) to [0] changes are a perf change recommended by jQuery docs.
agr
approved these changes
Dec 14, 2022
|
@joelverhagen I'm curious - was this invetsigation in response to a perf complaint, observation or hunch? |
Sorry, missed your comment prior to merge. It was something I noticed while accepting an ownership request on behalf of @clairernovotny 😃. She mentioned it's slow for her too. |
|
@joelverhagen Discussion point only--I wasn't blocking on it, was just wondering how it surfaced. Great improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves performance for the manage packages page. For a user with 1000 package IDs, it went from a 7 second page render time to 3 seconds.
There are two changes:
setPopoversmethod to run for each package.thisinstead of$(this).get(0)to get the DOM element. (improved cumulativesetPopoversexecution time from 4.381 seconds to 4.089 seconds.Perf before:
Perf after:
(tons on
setPopoverscalls removed)The page is still slow, but more usable than before.
Progress on #5877