Remove the client secret from AAD V2 authenticator #9340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only ever using the id_token which contains enough detail for NuGet.org sign in. The code response is not used. Progress on NuGet/Engineering#4099
agr
reviewed
Jan 5, 2023
...ication/Providers/AzureActiveDirectoryV2/AzureActiveDirectoryV2AuthenticatorConfiguration.cs
Outdated
Show resolved
Hide resolved
agr
approved these changes
Jan 5, 2023
zhhyu
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only ever using the id_token which contains enough detail for NuGet.org sign in. The code response is not used. Progress on https://github.com/NuGet/Engineering/issues/4099
The benefit here is that we have less secrets to rotate 😄.
I've confirmed the general approach with the team that owns the AAD SDK.