Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to external privacy link #9347

Merged
merged 4 commits into from
Feb 2, 2023
Merged

redirect to external privacy link #9347

merged 4 commits into from
Feb 2, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Jan 11, 2023

Privacy page https://www.nuget.org/policies/Privacy redirect to generic Microsoft privacy policy.

Addresses https://github.com/NuGet/Engineering/issues/4669

@lyndaidaii lyndaidaii requested a review from a team as a code owner January 11, 2023 00:33
@lyndaidaii lyndaidaii changed the title Remove external privacy link redirect to external privacy link Jan 11, 2023
agr
agr previously approved these changes Jan 24, 2023
@agr
Copy link
Contributor

agr commented Jan 24, 2023

Please fix the link to the issue being addressed.

@@ -276,6 +276,23 @@ public class TheGetAbsoluteReturnUrlMethod
}
}

public class GetExternalPrivayUrlMethod : TestContainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name typo.

Copy link
Contributor

@keylime-unicorn keylime-unicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to fix the typo @agr mentioned

@lyndaidaii
Copy link
Contributor Author

lyndaidaii commented Feb 2, 2023

LGTM! Just need to fix the typo @agr mentioned

@camigthompson, fixed typo, could you take a look again?

@lyndaidaii lyndaidaii merged commit 9602e0a into dev Feb 2, 2023
@drewgillies drewgillies mentioned this pull request Feb 6, 2023
6 tasks
@joelverhagen joelverhagen deleted the updatePrivacyLink branch August 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants