Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y][Fastpass] Add role attribute where aria-label attribute is used #9349

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

keylime-unicorn
Copy link
Contributor

Added the role="alert" attribute to the warning message for the third party package managers.

Addresses #9319

@keylime-unicorn keylime-unicorn requested a review from a team as a code owner January 11, 2023 22:14
advay26
advay26 previously approved these changes Jan 11, 2023
@advay26
Copy link
Member

advay26 commented Jan 11, 2023

Why do we need this b tag here at all? It doesn't seem to add anything to the display, and the surrounding div can be given the same 'aria-label' attribute, plus it already has the role="alert" attribute. Should we just remove the b tag completely?

@keylime-unicorn
Copy link
Contributor Author

keylime-unicorn commented Jan 11, 2023

@advay26 @drewgillies It's not supposed to add anything to the display at all. Basically, we ran into an issue a few months ago where we were told that the warning icon should alert the user that the following text is a warning (essentially just read out "warning" before reading out the text). The problem is that the only way to get this to happen while still leaving warning icon itself hidden from screen readers is to add a separate element that has no visual aspect and simply makes the screen reader read out the "warning" text.

@keylime-unicorn keylime-unicorn merged commit b0be388 into dev Jan 12, 2023
@agr agr mentioned this pull request Jan 26, 2023
10 tasks
@joelverhagen joelverhagen deleted the a11y-fix-aria-label-b branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants