More telemetry for downloads service. #9361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9352.
We have a weird situation when downloads.v1.json, Gallery DB and Search service all align on a downloads count for a certain package, yet the number displayed in the package list is different.
It should come from DB:
NuGetGallery/src/NuGetGallery/Helpers/ViewModelExtensions/PackageViewModelFactory.cs
Line 58 in c1ccf24
But some EF interception magic happens and it is actually ends up being populated from data retrieved by CloudDownloadCountService and it is unclear if it actually refreshes the statistics data fully. To investigate the issue from that angle, more telemetry is added to that service.