Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify warning message on display package page when missing readme #9365

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Modify warning message on display package page when missing readme #9365

merged 5 commits into from
Feb 13, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Feb 1, 2023 •
edited
Loading

Summary of the changes (in less than 80 characters):

  • Introduced new warning message on package display page when package is missing readme
  • only display warning message to package authors
  • added feature flag to this new warning

Before:
Screenshot 2023-01-31 140711
After:
Screenshot 2023-01-31 140647

Addresses https://github.com/NuGet/Engineering/issues/4695

@lyndaidaii lyndaidaii marked this pull request as ready for review February 1, 2023 01:01
@lyndaidaii lyndaidaii requested a review from a team as a code owner February 1, 2023 01:01
joelverhagen
joelverhagen requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@lyndaidaii lyndaidaii changed the title modify warning message on display package page when missing readme Modify warning message on display package page when missing readme Feb 7, 2023
@lyndaidaii
Copy link
Contributor Author

@dannyjdev, @joelverhagen, @agr , could you help take another look? let me know need any change. thanks!

@lyndaidaii lyndaidaii merged commit 8ff5267 into dev Feb 13, 2023
@joelverhagen joelverhagen deleted the updatePackageDetailsPageWarningMess branch August 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyjdev dannyjdev dannyjdev left review comments

@agr agr agr approved these changes

@joelverhagen joelverhagen joelverhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyndaidaii @joelverhagen @agr @dannyjdev