Search-by-TFM Bug Bash feedback

[advay26]

Addresses

1. [Search-by-TFM Bug Bash] Prerel parameter uppercase/lowercase inconsistency #9367
2. [Search-by-TFM Bug Bash] Frameworks and tfms params not ordered correctly #9368
3. [Search-by-TFM Bug Bash] Frameworks and tfms params have a trailing comma #9369
4. [Search-by-TFM Bug Bash] TFM section should be expanded on page load if a TFM is selected #9370
5. [Search-by-TFM Bug Bash] packageType param should appear after frameworks and tfms in the url #9371
6. [Search-by-TFM Bug Bash] Box around the TFM section arrows is hidden by the box below it #9375
7. [NuGet.org Bug]: The search bar disappears when browsing packages under a package owner #9377
8. [NuGet.org Bug]: A second search bar blinks when changing the selection of "Sort by" #9376

This PR addresses some of the issues flagged by the Search-by-TFM bug bash:

1. The Prerelease url parameter sometimes had an uppercase boolean ('True') and sometimes a lowercase boolean ('true'). It will always show a lowercase boolean now.
   [Search-by-TFM Bug Bash] Prerel parameter uppercase/lowercase inconsistency #9367
2. The frameworks and tfms parameters were being added to the query string in the order that the user selected them, rather than the order of the checkboxes in the UI. This has been fixed.
   [Search-by-TFM Bug Bash] Frameworks and tfms params not ordered correctly #9368
3. The frameworks and tfms parameters always ended in a comma (net, ; net5.0,net472,). This has been fixed.
   [Search-by-TFM Bug Bash] Frameworks and tfms params have a trailing comma #9369
4. Previously, all TFM sections were always collapsed when the page loaded. Now, if any individual TFMs have been selected, their TFM sections will be expanded when the page loads.
   [Search-by-TFM Bug Bash] TFM section should be expanded on page load if a TFM is selected #9370
5. The packageType query parameter was before frameworks and tfms in the url, but appears after them in the UI. This has been fixed so that the frameworks and tfms params appear before packageType in the url.
   [Search-by-TFM Bug Bash] packageType param should appear after frameworks and tfms in the url #9371
6. The box around the framework generation collapsible arrows (when they're selected/in focus) was distorted by the box below it. Some of the bottom part of the box was hidden. This has been fixed.
   [Search-by-TFM Bug Bash] Box around the TFM section arrows is hidden by the box below it #9375

UPDATE: Added a small fix that addresses 2 other bugs:

1. Search bar disappears on the Profiles page. We needed to remove the default search bar on the Search page, but the search bar was being removed from the Profiles page too with the same javascript code. We now use a ViewBag property, the same way that the Home page does, instead of javascript. With these changes, the search bar removal will only happen on the Search page.
   [NuGet.org Bug]: The search bar disappears when browsing packages under a package owner #9377
2. An extra Search bar flickers before disappearing when the search page is rendering. The switch from the javascript code to the ViewBag property fixes this too.
   [NuGet.org Bug]: A second search bar blinks when changing the selection of "Sort by" #9376

[advay26]

This btn-filter class is no longer used in the code.

[loic-sharma]

Do these issues need to be private? Consider moving them to NuGet/NuGetGallery so that the .NET community can participate, these search improvements are really interesting to follow! 😄

[advay26]

@loic-sharma Done! I should've done that in the first place, so thanks for calling it out! 😊

[advay26]

UPDATE: Added a small fix that addresses 2 other bugs:

1. Search bar disappears on the Profiles page. We needed to remove the default search bar on the Search page, but the search bar was being removed from the Profiles page too with the same javascript code. We now use a ViewBag property, the same way that the Home page does, instead of javascript. With these changes, the search bar removal will only happen on the Search page.
   [NuGet.org Bug]: The search bar disappears when browsing packages under a package owner #9377
2. An extra Search bar flickers before disappearing when the search page is rendering. The switch from the javascript code to the ViewBag property fixes this too.
   [NuGet.org Bug]: A second search bar blinks when changing the selection of "Sort by" #9376