Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two small UI issues (README bg color, Script & Interactive info) #9385

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix two small UI issues (README bg color, Script & Interactive info) #9385

merged 2 commits into from
Feb 10, 2023

Conversation

joelverhagen
Copy link
Member

Fix #9354 and #9355.

  1. Use a new, prescribed info text for the Script & Interactive tab: [NuGet.org Bug]: Information on the Script & Interactive usage tab isn't quite accurate  #9354 (comment).
  2. Make the code block bg color match the rest. I had to darken the comment color to avoid contrast issues.
  3. Change the bg color of the README section on the upload page to be white. This fixes link contrast issues (newly discovered problem).

@joelverhagen joelverhagen requested a review from a team as a code owner February 10, 2023 14:10
@joelverhagen joelverhagen merged commit 0927359 into dev Feb 10, 2023
@joelverhagen joelverhagen deleted the jver-double branch February 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyndaidaii lyndaidaii lyndaidaii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelverhagen @lyndaidaii