Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fabric Core to 11.0.1 #9407

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Update Fabric Core to 11.0.1 #9407

merged 3 commits into from
Mar 2, 2023

Conversation

dannyjdev
Copy link
Contributor

@dannyjdev dannyjdev commented Feb 28, 2023

Changes

  • Updated version 7.3.0 to 11.0.1
  • Removed SquaredShape icon since it's no longer needed.

Addresses: https://github.com/NuGet/Engineering/issues/4756

@dannyjdev dannyjdev requested a review from a team as a code owner February 28, 2023 21:11
@joelverhagen
Copy link
Member

What kind of testing did you do you make sure we didn't regress the look-n-feel? IIRC we use more than just the icons from fabric. Maybe some typography ones are used... Would it be worth visually inspecting all places that use an ms-* CSS class?

@dannyjdev
Copy link
Contributor Author

What kind of testing did you do you make sure we didn't regress the look-n-feel? IIRC we use more than just the icons from fabric. Maybe some typography ones are used... Would it be worth visually inspecting all places that use an ms-* CSS class?

I actually did that, inspected the icons and checked if something looked different. And no, everything I checked looked fine.

@lyndaidaii
Copy link
Contributor

Have we ever used this SquaredShape?

@dannyjdev
Copy link
Contributor Author

Have we ever used this SquaredShape?

Yes, I used it on the frameworks tab, it was the only place I add it.

@dannyjdev dannyjdev merged commit ebd782b into dev Mar 2, 2023
@joelverhagen joelverhagen deleted the dev-dj-updatefabriccore branch August 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants