Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard focus is not clearly visible #9456

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Keyboard focus is not clearly visible #9456

merged 3 commits into from
Apr 10, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Apr 6, 2023

Summary of the changes (in less than 80 characters):

Problem: Keyboard focus is not clearly visible because of overflow was set to hidden.

Fix: Changed to visible since the button name length is fix, won't be overflow.

For "Eidt, Regenerate, Delete" buttons, it's ok to

Addresses https://github.com/NuGet/Engineering/issues/4827

@lyndaidaii lyndaidaii requested a review from a team as a code owner April 6, 2023 21:50
@lyndaidaii lyndaidaii changed the title overflow Keyboard focus is not clearly visible Apr 6, 2023
@agr
Copy link
Contributor

agr commented Apr 7, 2023

Could you please post screenshots?

@lyndaidaii
Copy link
Contributor Author

Could you please post screenshots?

not able to provide with the screenshots since keyboard interaction. video might work. let me upload it.

@agr
Copy link
Contributor

agr commented Apr 8, 2023

As far as I understand, this
image
gets changed to this
image

Given that .package-list class name seems a bit out of place on an API key management page and that we have an explicit overflow-y: hidden for .package-list li selector


I would guess that combination of elements is used elsewhere, too. I wonder if the focus indication is broken there, too.

@agr
Copy link
Contributor

agr commented Apr 8, 2023

OK, it is on package list page and respective elements there are not focusable.

@lyndaidaii lyndaidaii merged commit e088121 into dev Apr 10, 2023
@joelverhagen joelverhagen deleted the acc22 branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants