Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y bug] Package Manager tab on Package details reads as both selected and expanded #9460

Merged
merged 2 commits into from
Apr 11, 2023
Merged

[A11y bug] Package Manager tab on Package details reads as both selected and expanded #9460

merged 2 commits into from
Apr 11, 2023

Conversation

dannyjdev
Copy link
Contributor

Changes

  • Removed aria-expanded from DisplayPackage for element that should only have aria-selected.
  • Added comment stating that data-toggle="tab" adds aria-expanded every time it's selected/active. So, it needed to be removed when the script is loaded and after the shown.bs.tab event.

Addresses #9418

@dannyjdev dannyjdev requested a review from a team as a code owner April 7, 2023 23:55
@dannyjdev dannyjdev merged commit 58fec4c into dev Apr 11, 2023
@joelverhagen joelverhagen deleted the dev-dj-a11y-pmexpanded branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelverhagen joelverhagen joelverhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyjdev @joelverhagen