-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard focus on owner list on package detail page #9470
Conversation
Can you test this with a very long username? And a very long username containing a character like a hyphen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just wanted to make sure long usernames were tested.
2ff2e42
original doesn't work for long username. Put new changes. it looks like below if we would like to keep overflow hidden, otherwise it needs set overflow visible. It looks fine if we are ok to have wider right white space for long username. |
I don't think we should widen the panel. Hiding the overflow with ellipsis (this is previous behavior) is right. |
Summary of the changes (in less than 80 characters):
Before:
After:
Addresses: https://github.com/NuGet/Engineering/issues/4827