Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard focus on owner list on package detail page #9470

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Apr 18, 2023

Summary of the changes (in less than 80 characters):

Before:
image

After:
image

Addresses: https://github.com/NuGet/Engineering/issues/4827

@lyndaidaii lyndaidaii requested a review from a team as a code owner April 18, 2023 00:53
@lyndaidaii lyndaidaii changed the base branch from main to dev April 18, 2023 00:54
@joelverhagen
Copy link
Member

Can you test this with a very long username? And a very long username containing a character like a hyphen?

joelverhagen
joelverhagen previously approved these changes Apr 18, 2023
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just wanted to make sure long usernames were tested.

@lyndaidaii
Copy link
Contributor Author

lyndaidaii commented Apr 18, 2023

LGTM, I just wanted to make sure long usernames were tested.

original doesn't work for long username. Put new changes. it looks like below if we would like to keep overflow hidden, otherwise it needs set overflow visible. It looks fine if we are ok to have wider right white space for long username.
any preference? personally, I think it's better to keep overflow hidden to avoid long username breaking UI. @joelverhagen, please let me know do you think.

MicrosoftTeams-image (5)

@joelverhagen
Copy link
Member

I don't think we should widen the panel. Hiding the overflow with ellipsis (this is previous behavior) is right.

@lyndaidaii lyndaidaii merged commit bbbea72 into dev Apr 18, 2023
@joelverhagen joelverhagen deleted the acessOverflow branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants