Clarify what a package being available means #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Learn Build status updates of commit b2ef23c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 74e44e2: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
erdembayar
approved these changes
Nov 18, 2024
donnie-msft
requested changes
Nov 18, 2024
|
Learn Build status updates of commit 1303f7c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
martinrrm
approved these changes
Nov 19, 2024
joelverhagen
approved these changes
Nov 19, 2024
donnie-msft
approved these changes
Nov 19, 2024
zivkan
approved these changes
Nov 19, 2024
Comment on lines
39
to
42
| If the client knows a package ID and wants to discover which package versions the package source has available, the | ||
| client can construct a predictable URL to enumerate all package versions. This list is meant to be a "directory | ||
| client can construct a predictable URL to enumerate all package versions. Every version listed in this list must be available for download. | ||
| This list is meant to be a "directory | ||
| listing" for the package content API mentioned below. |
There was a problem hiding this comment.
I suggest reformatting this to one complete sentence per line.
nkolev92
force-pushed
the
dev-nkolev92-contentIMprovements
branch
from
1303f7c to
95ca569
Compare
|
Learn Build status updates of commit 95ca569: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit ec06f03: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See motivation: NuGet/Home#13930 (comment).
tldr; If a package content resource lists a package as available, it should be able to download.
Being unavailable breaks the contract.