Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Restoring fails when project/solution file uses spaces #866

Closed
1 of 7 tasks
bddckr opened this issue Aug 26, 2019 · 1 comment
Closed
1 of 7 tasks

Restoring fails when project/solution file uses spaces #866

bddckr opened this issue Aug 26, 2019 · 1 comment
Labels

Comments

@bddckr
Copy link

bddckr commented Aug 26, 2019

🐛 Bug Report

Expected behavior

Spaces in file names should result in no errors during NuKeeper's restore operation.

Reproduction steps

Run NuKeeper in a folder that uses My Solution.sln.

Configuration

Version: 0.25.0

Platform if applicable:

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker

This seems to fix it for me:

var restoreCommand = $"restore {file.Name} {sourcesCommandLine} -NonInteractive";

- var restoreCommand = $"restore {file.Name} {sourcesCommandLine}  -NonInteractive";
+ var restoreCommand = $"restore \"{file.Name}\" {sourcesCommandLine}  -NonInteractive";
@stale
Copy link

stale bot commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2020
AnthonySteele pushed a commit to AnthonySteele/NuKeeper that referenced this issue May 18, 2020
NuKeeperDotNet#866
When there is a space in the file name, it needs to be quoted on the commandline
As before, `ArgumentEscaper.EscapeAndConcatenate` handles this
@AnthonySteele AnthonySteele mentioned this issue May 18, 2020
2 tasks
AnthonySteele added a commit that referenced this issue May 18, 2020
* A fix for another escaping issue
#866
When there is a space in the file name, it needs to be quoted on the commandline
As before, `ArgumentEscaper.EscapeAndConcatenate` handles this

* Changed my mind on the logging

Co-authored-by: Anthony Steele <[email protected]>
@stale stale bot closed this as completed May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant