Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration to enable absolute paths #8

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

fragsalat
Copy link

I recognized that all imports of this plugin are relative to the current document. Because I don't like this for several reasons I added a backward compatible configuration to make the paths absolute. As well I added a sourceRoot configuration which allows the users to specify from where to import since many projects are not relative to the workspace root.

Examples:
src/app/main.js requires src/app/view.js with {absolute: true, sourceRoot: 'src'}
= app/view.js
src/app/main.js requires src/app/view.js with {absolute: true}
= src/app/view.js
src/app/main.js requires src/app/view.js with {}
= ./view.js

@fragsalat
Copy link
Author

@NuclleaR Can you please review this and release a new version if it's ok for you?

Would be cool if not everyone publishes a new version of the same plugin. Right now there are 3 out there on vs code market^^

@NuclleaR NuclleaR merged commit 27ab939 into NuclleaR:master Mar 21, 2018
@fragsalat
Copy link
Author

Thx for merging so quick :)

When do you plan to release a new version?

@NuclleaR
Copy link
Owner

@fragsalat maybe today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants