chore: reduce proc-macro dep strum #169
Conversation
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
If comfy-table wouldn't have such a good test coverage, I would actually advise against such a change.
Manually implemented iterators for enums are usually a bad idea as it's really easy to forget to adjust them if new variants are added. And there's no way to throw a lint error for stuff like this.
But as you said, that enum should be relatively stable and even if something would change, we would notice via the test coverage, so in this case I think this is a neat change :)
Signed-off-by: tison <[email protected]>
| const fn components() -> [TableComponent; 19] { | ||
| [ | ||
| TableComponent::LeftBorder, | ||
| TableComponent::RightBorder, | ||
| TableComponent::TopBorder, | ||
| TableComponent::BottomBorder, | ||
| TableComponent::LeftHeaderIntersection, | ||
| TableComponent::HeaderLines, | ||
| TableComponent::MiddleHeaderIntersections, | ||
| TableComponent::RightHeaderIntersection, | ||
| TableComponent::VerticalLines, | ||
| TableComponent::HorizontalLines, | ||
| TableComponent::MiddleIntersections, | ||
| TableComponent::LeftBorderIntersections, | ||
| TableComponent::RightBorderIntersections, | ||
| TableComponent::TopBorderIntersections, | ||
| TableComponent::BottomBorderIntersections, | ||
| TableComponent::TopLeftCorner, | ||
| TableComponent::TopRightCorner, | ||
| TableComponent::BottomLeftCorner, | ||
| TableComponent::BottomRightCorner, | ||
| ] | ||
| } |
There was a problem hiding this comment.
Manually implemented iterators for enums are usually a bad idea as it's really easy to forget to adjust them if new variants are added. And there's no way to throw a lint error for stuff like this.
Yes. This is the original reason we use a macro to generate.
I try to use an internal method return [TableComponent; 19] so that the compiler can help a bit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 96.75% 96.59% -0.16%
==========================================
Files 16 16
Lines 1754 1793 +39
==========================================
+ Hits 1697 1732 +35
- Misses 57 61 +4 ☔ View full report in Codecov by Sentry. |
|
Seems the CI failure unrelated? |
|
Yeah. Rust toolchain for wasm32-wasi is broken again :D |
|
Thx for the contribution :) |
|
@Nukesor thanks for creating such a good crate! I've successfully use it in generating the table format output of our database :D Do you have a plan for cutting a release So that I can bump in the application? |
|
There're a few critical bug fixes that I want to include in the next release. I'm not sure when I'll find the time to address those. |
Is there a traking issue or your can list them here? Perhaps I can spend some time on it but I can't promise it :P |
Get rid of proc-macro deps for:
@Nukesor this patch may be more like a personal preference, so it's up to you to accept. Typically, if the
TableComponentis stable, we don't need theEnumIterfor convenience but just finalize it.Otherwise, I'd prefer use enum-iterator who has no transitive deps and do exactly the same thing.