Add eslint #195
Merged
Add eslint #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
commented
Jun 24, 2024
| // @license MIT | ||
| // @version 6.9.3 | ||
| // @description Enhances the Steam Inventory and Steam Market. | ||
| // @match https://steamcommunity.com/id/*/inventory* |
There was a problem hiding this comment.
I changed @include to @match as the userscripts lint suggested that for manifest v3.
xPaw
commented
Jun 24, 2024
|
|
||
| /* disable some eslint rules until the code is cleaned up */ | ||
| /* global unsafeWindow, luxon, jQuery, async, localforage */ | ||
| /* eslint no-undef: off, no-unused-vars: off */ |
There was a problem hiding this comment.
These rules are disabled since the code needs some cleanup to fix them.
xPaw
commented
Jun 24, 2024
| @@ -2209,8 +2212,8 @@ | |||
| var arr = []; | |||
|
|
|||
| for (var child in getActiveInventory().m_rgChildInventories) { | |||
| for (var key in getActiveInventory().m_rgChildInventories[child].m_rgAssets) { | |||
| var value = getActiveInventory().m_rgChildInventories[child].m_rgAssets[key]; | |||
| for (const key in getActiveInventory().m_rgChildInventories[child].m_rgAssets) { | |||
There was a problem hiding this comment.
Vars changed to const/let to reduce scope because they were redefining these.
|
Thanks for the PRs @xPaw. This now has a conflict, I think because of the match changes. |
|
@Nuklon i've fixed that and opened a few more prs 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only basic config for now, more rules can be enabled in the future. I also added a CI job to run this.