Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #222 #225

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix issue #222 #225

merged 3 commits into from
Sep 26, 2024

Conversation

SeRi0uS007
Copy link
Contributor

Trying to fix raw string issue for GetPriceValueAsInt
#222

Trying to fix raw string issue for GetPriceValueAsInt
@SeRi0uS007
Copy link
Contributor Author

I will check with amounts >1000
I think I forgot about it

@xPaw
Copy link
Contributor

xPaw commented Aug 19, 2024

You can use v_currencyformat(1234567890, 'UAH') to loop some random values over all currencies to test if you want.

Update regex for more price formats
@SeRi0uS007
Copy link
Contributor Author

Yep, I definitely missed prices over 1000.
In addition, the previous version did not consider that a whole part of the price could be without a separator at all.

Now, it seems, I have considered everything:
img

code.user.js Outdated Show resolved Hide resolved
Make it more elegant
@Nuklon
Copy link
Owner

Nuklon commented Sep 25, 2024

Is this done now/working?

@SeRi0uS007
Copy link
Contributor Author

@Nuklon , yep
It's working

@Nuklon Nuklon merged commit e43c048 into Nuklon:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants