Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against ember-resources@v7 #392

Merged
merged 27 commits into from
Jan 21, 2024
Merged

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Jan 17, 2024

Trying to actually get all the try scenarios to pass now is proving quite difficult.

I may need to create more test-apps for different scenarios instead of relying on ember-try.

So far, this PR uses a different lockfile per workspace, rather than the traditional single lockfile.

Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NullVoxPopuli NullVoxPopuli force-pushed the test-against-ember-resourcesc-7 branch from f8bea15 to 965dc3f Compare January 20, 2024 17:57
Copy link
Contributor

Some tests with 'continue-on-error: true' have failed:

  • test-embroider-app :: ember-lts-4.8

Created by continue-on-error-comment

@NullVoxPopuli NullVoxPopuli merged commit f6aa10f into main Jan 21, 2024
33 checks passed
@NullVoxPopuli NullVoxPopuli deleted the test-against-ember-resourcesc-7 branch January 21, 2024 22:54
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Jan 21, 2024
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant