[16.0][ADD] sale_lead_time #3539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
16.0-add-sale_lead_time_profile
branch
from
2619b9b to
e9a7924
Compare
rousseldenis
approved these changes
Jan 16, 2025
yostashiro
reviewed
Jan 16, 2025
AungKoKoLin1997
force-pushed
the
16.0-add-sale_lead_time_profile
branch
2 times, most recently
from
d0fe46b to
0ff8e28
Compare
mmequignon
reviewed
Jan 17, 2025
Comment on lines
27
to
44
| score += 1 | ||
| else: | ||
| return -1 | ||
| if self.partner_id: | ||
| if partner == self.partner_id: | ||
| score += 3 | ||
| else: | ||
| return -1 | ||
| elif self.state_id: | ||
| if partner.state_id == self.state_id: | ||
| score += 2 | ||
| else: | ||
| return -1 | ||
| elif self.country_id: | ||
| if partner.country_id == self.country_id: | ||
| score += 1 | ||
| else: | ||
| return -1 |
There was a problem hiding this comment.
I would make those configurable. Also, I think it lacks some comments. Why is partner +3 and not +42? I feel like this should be configured on the company.
And as I see it, I'm thinking that maybe we could sum values.
For a given profile, profile score is warehouse score + partner score + …, according to what the customer wants to.
|
@mmequignon Thanks for your comments! Can you please check the updated code? |
yostashiro
force-pushed
the
16.0-add-sale_lead_time_profile
branch
from
d8232e8 to
12203a8
Compare
AungKoKoLin1997
changed the title
AungKoKoLin1997
force-pushed
the
16.0-add-sale_lead_time_profile
branch
3 times, most recently
from
f1cc0f4 to
d4a7f4d
Compare
yostashiro
reviewed
Jan 21, 2025
sale_lead_time/models/sale_order.py
Outdated
| continue | ||
| partner_address_domain = rec._get_partner_address_domain() | ||
| warehouse_domain = rec._get_warehouse_domain() | ||
| domain = expression.AND([partner_address_domain, warehouse_domain]) |
There was a problem hiding this comment.
Forgot to include the company in the domain.
Suggested change
| domain = expression.AND([partner_address_domain, warehouse_domain]) | |
| domain = expression.AND([partner_address_domain, warehouse_domain, [("company_id", "=", rec.company_id.id)]]) |
yostashiro
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Code review.
@AungKoKoLin1997 Can you please squash commits?
| @@ -0,0 +1,4 @@ | |||
| This module enhances the sales order process by adding a delivery_lead_time that is | |||
There was a problem hiding this comment.
Suggested change
| This module enhances the sales order process by adding a delivery_lead_time that is | |
| This module enhances the sales order process by adding a Delivery Lead Lime that is |
sale_lead_time/readme/CONFIGURE.rst
Outdated
| | Japan | Tokyo | | 2nd WH | 7.0 | N/A for warehouse mismatch | | ||
| +---------+-------+---------+-----------+------------------+-------------------------------+ | ||
|
|
||
| As a result, 5.0 days of the Delivery Lead Time will be proposed for the sales order. |
There was a problem hiding this comment.
Suggested change
| As a result, 5.0 days of the Delivery Lead Time will be proposed for the sales order. | |
| The profile with the highest score is considered the best match, and therefore, a | |
| Delivery Lead Time of 5.0 days will be proposed for the sales order. |
AungKoKoLin1997
force-pushed
the
16.0-add-sale_lead_time_profile
branch
from
d318b86 to
d58c6e8
Compare
AungKoKoLin1997
force-pushed
the
16.0-add-sale_lead_time_profile
branch
from
d58c6e8 to
c818996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module enhances the sales order process by adding a delivery_lead_time that is determined based on the most closely matching lead time profile. This time is then incorporated into the customer_lead of each sale order line, optimizing delivery scheduling based on specific lead time configurations.
@qrtl QT4790