Skip to content

Commit

Permalink
Merge pull request #130 from kba/docker-entrypoint
Browse files Browse the repository at this point in the history
docker: entrypoint and cmd should be empty
  • Loading branch information
kba authored Nov 5, 2019
2 parents 553d8e6 + 45e753f commit 06ea6ae
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ in a spec-conformant way. Besides, it locally installed and containerized

## Shell entrypoint

The `ENTRYPOINT` should a be a shell call not the tool provided. A non-shell
entrypoint would restrict MP to just one tool.
No `CMD` should be provided.

No `ENTRYPOINT` should be provided.

If `CMD` or `ENTRYPOINT` are provided, they should be empty arrays.

## `/data` as volume

Expand All @@ -30,6 +33,8 @@ FROM ocrd:core
VOLUME ["/data"]

# RUN-commands to install requirements, build and install
# e.g.
# apt-get install -y curl

ENTRYPOINT ["/bin/sh", "-c"]
ENTRYPOINT []
```

0 comments on commit 06ea6ae

Please sign in to comment.