Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Type.GetGenericTypeDefinition just once in _isDeltaOfT #1189

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

senioroman4uk
Copy link
Contributor

@senioroman4uk senioroman4uk commented Mar 5, 2024

Fix multiple calls to GetGenericTypeDefinition in ODataSerializerContext.cs

fixes #1188

@senioroman4uk senioroman4uk marked this pull request as draft March 5, 2024 02:54
@senioroman4uk senioroman4uk force-pushed the senioroman4uk/fix-is-delta-of-t branch from f7e939b to aa48739 Compare March 5, 2024 03:08
@senioroman4uk
Copy link
Contributor Author

senioroman4uk commented Mar 5, 2024

Test results
Before
image

After
image

@senioroman4uk senioroman4uk force-pushed the senioroman4uk/fix-is-delta-of-t branch from b1734a8 to 62d052b Compare March 5, 2024 04:29
@senioroman4uk senioroman4uk marked this pull request as ready for review March 5, 2024 04:37
@gathogojr gathogojr merged commit 12d6080 into OData:main Mar 7, 2024
1 check passed
@senioroman4uk senioroman4uk deleted the senioroman4uk/fix-is-delta-of-t branch March 19, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODataSerializerContext.IsDeltaOfT ReadsGenericTypeDefinition multiple times for the same type
3 participants