-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ODL version #1253
Merged
Merged
Update ODL version #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
force-pushed
the
fix/update_odl_version
branch
from
June 3, 2024 13:40
f723f2f
to
bb15378
Compare
xuzhg
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is straightforward and looks good to me
ElizabethOkerio
force-pushed
the
fix/update_odl_version
branch
from
June 4, 2024 06:47
5d5cc12
to
ce5d4bc
Compare
gathogojr
reviewed
Jun 4, 2024
test/Microsoft.AspNetCore.OData.Tests/Extensions/SerializableErrorExtensionsTests.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jun 4, 2024
test/Microsoft.AspNetCore.OData.Tests/Extensions/SerializableErrorExtensionsTests.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jun 4, 2024
test/Microsoft.AspNetCore.OData.Tests/Extensions/SerializableErrorExtensionsTests.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jun 4, 2024
src/Microsoft.AspNetCore.OData/Extensions/SerializableErrorExtensions.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jun 4, 2024
src/Microsoft.AspNetCore.OData/Extensions/SerializableErrorExtensions.cs
Outdated
Show resolved
Hide resolved
habbes
approved these changes
Jun 4, 2024
ElizabethOkerio
force-pushed
the
fix/update_odl_version
branch
from
June 4, 2024 12:00
b3251aa
to
4db688a
Compare
anasik
pushed a commit
to anasik/AspNetCoreOData
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the ODL version to
8.0.0-preview.3
. Since8.0.0-preview.3
had some breaking changes, I've also made some updates like:IContainerBuilder
and usingMicrosoft.Extensions.DependencyInjection
instead.ODataSimplifiedOptions
and usedODataMessageReaderSettings
instead since we got rid of this class inODL 8.0.0-preview.3
ErrorCode
toCode
and the way the ODataInnerError is initialized fromnew ODataInnerError { Message = ConvertModelStateErrors(modelStateError) };
tonew Dictionary<string, ODataValue> { { "Message", new ODataPrimitiveValue(ConvertModelStateErrors(modelStateError)) } });
This PR also updates
Microsoft.AspNetCore.OData
version to9.0.0.preview-1