update DI settings #1344
Merged
update DI settings #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marabooy
requested review from
habbes,
xuzhg,
WanjohiSammy,
gathogojr and
DButoyez
and removed request for
habbes
habbes
reviewed
Nov 12, 2024
| @@ -38,7 +38,7 @@ public static IServiceCollection AddDefaultWebApiServices(this IServiceCollectio | |||
| // ReaderSettings and WriterSettings are registered as prototype services. | |||
| // There will be a copy (if it is accessed) of each prototype for each request. | |||
| #pragma warning disable CS0618 // ReadUntypedAsString is obsolete in ODL 8. | |||
| services.AddSingleton(new ODataMessageReaderSettings | |||
There was a problem hiding this comment.
I wonder why we had AddSingleton in the first place. Also check whether the comments above are still relevant, we no longer use "prototypes".
habbes
approved these changes
Nov 12, 2024
WanjohiSammy
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message reader and Writer have the wrong scope in the DI container.
This could cause some issues whenever users retrieve and write to them in the scope of a request.
Fixes #1337 by updating the dependencies to 8.0.2 as well as moving reader and writer settings to scoped.
This includes OData/odata.net#3058