-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: add support for ndpi-like plugins - v3 #12091
Conversation
For library users and plugins that need to hook into the thread life cycle, perhaps to initialize some thread storage.
Provide a way for library/plugin users to register a callback that will be called prior to an EVE record being closed. The callback will be passed ThreadVars, Packet, and Flow pointers if available, as well as private user data.
Needed for changes to output-eve.h.
Allows initialization to be done early, so the table is ready for dynamic registration by plugins which are loaded before signature setup.
rust-bindings.h was not being installed with rust-bindings.h, and its now pulled in by a header used for plugin support, so make sure its installed. We first attempt to install the "dist" version if exists, otherwise install the "gen" one. Also install the "gen" even if the "dist" one exists, as its going to be newer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12091 +/- ##
==========================================
- Coverage 83.25% 83.10% -0.16%
==========================================
Files 910 913 +3
Lines 257571 257785 +214
==========================================
- Hits 214450 214234 -216
- Misses 43121 43551 +430
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Some style comments inline.
Rebase of #11985 for nDPI PR.